-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper templates to Assembler (WIP) #7532
Conversation
@richtabor Sorry could you rebase; there's conflict after I merged #7529 😄 |
5f133df
to
1650c4e
Compare
The template hierarchy can be a confusing concept to grasp even for experienced developers. I would advocate for moving in the direction of treating templates more like simple wrappers leaving pages to contain your sites content. This is something core needs to address but the approach here at least begins to move in that direction. It also plays nicely into the idea that the showcase can become a much more composable / mix and match type experience that leads into the assembler. If most themes are driven by the same pattern library, then applying a homepage from the showcase is as simple as copying the pattern or page. All that to say, given the confusion on Dotcom surrounding templates, I think this approach would be a worthwhile experiment. |
This makes me think of an idea connected to something @SaxonF shared earlier. It seems like we could never use home.html and front-page.html, and instead rely on reading settings to control the contents of the home page. This would make it more important to have reading settings in the Site Editor. |
I made an alternate PR to get Assembler templates in a decent place; we can discuss/explore this method in the meantime. |
Closing for now, as the alternate was merged. #7538 |
Updates the templates for Assembler, as a follow-up for #7528.
An exploration into simpler templates v. page content
This PR reduces the template load to index, archive, and single, as follows:
Index
Archive
Archive
Caveats
In the Assembler flow on WordPress.com, we would need to create a "Home" page and assign it to the homepage via the reading settings option—instead of creating/augmenting a home.html template.
Props @SaxonF.