Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Shore: addressing dotorg feedback #8076

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Sep 5, 2024

This PR addresses the dotorg feedback for this theme:

https://themes.trac.wordpress.org/ticket/187526

  • Skip links
  • Image license

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Preview changes

I've detected changes to the following themes in this PR: The Shore.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@MaggieCabrera
Copy link
Contributor Author

This one has the same problem with the midjourney images. I made the other fixes, will leave this PR here in case we want to change the images for dotorg @beafialho @jasmussen

@jasmussen
Copy link
Member

Current instinct: we can merge and launch this on WP.com pending further clarification on requirements, and then hope a theme of the same name doesn't land on wp.org in the mean time. Depending on the outcome, we can then either replace the demo content images for the core version, not launch it at all, or otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants