-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme Assembler: Fix radio control height css issue #8186
base: trunk
Are you sure you want to change the base?
Conversation
Preview changesI've detected changes to the following themes in this PR: Assembler. I will update this comment with the latest preview links as you push more changes to this PR. |
Theme-Check resultsassembler: No changes required ✅.💡 RECOMMENDED (1)
ℹ️ INFO (1)
|
@@ -89,6 +89,10 @@ input:not([type=submit]):focus, | |||
outline: 1px solid currentColor; | |||
} | |||
|
|||
.wp-block-jetpack-contact-form-container input[type="radio"] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix this in a less specific way that works for all radio input forms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have followed the selector's example in the same style file that changes contact form fields.
Lines 54 to 66 in 13e2539
.wp-block-jetpack-contact-form-container .wp-block-jetpack-contact-form label { | |
display: inline-block; | |
font-size: var(--wp--preset--font-size--small); | |
margin-bottom: 0.25em; | |
font-weight: inherit; | |
} | |
textarea, | |
input:not([type=submit]):not([type=checkbox]), | |
.wp-block-post-comments-form textarea, | |
.wp-block-post-comments-form input:not([type=submit]):not([type=checkbox]), | |
.jetpack-contact-form .jetpack-field .jetpack-field__input, | |
.jetpack-contact-form .jetpack-field .jetpack-field__textarea { |
I found it safer since I'm not 100% familiar with this particular theme.
Changes proposed in this Pull Request:
Fixes radio control height issue.
Related issue(s):
Closes #7959