Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Assembler patterns #8248

Draft
wants to merge 26 commits into
base: trunk
Choose a base branch
from
Draft

Add Assembler patterns #8248

wants to merge 26 commits into from

Conversation

richtabor
Copy link
Contributor

@richtabor richtabor commented Oct 9, 2024

This is an experimental pr exploring a number of improvements collectively. I'm splitting out these into individual pull requests.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Preview changes

I've detected changes to the following themes in this PR: Assembler, DOS, Epi, LeanCV.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@richtabor richtabor force-pushed the add/assembler-patterns branch from d8d6853 to 1646475 Compare December 5, 2024 16:29
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Theme-Check results

assembler: There are required changes on the theme ❌.

❎ REQUIRED

  • blueprint-content.xml XML file found. This file must not be in the production version of the theme.

dos: There are required changes on the theme ❌.

❎ REQUIRED

  • Screenshot is wrong size! Detected: 1440x1080. Maximum allowed size is 1200x900px.
💡 RECOMMENDED (1)
  • Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.

epi: There are required changes on the theme ❌.

❎ REQUIRED

  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).

leancv: No changes required ✅.

⚠️ WARNING (1)
  • Found ="<?php esc_html_e(' src='<?php echo esc_url( get_styleshee

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Theme-Check results

assembler: There are required changes on the theme ❌.

❎ REQUIRED

  • blueprint-content.xml XML file found. This file must not be in the production version of the theme.

dos: There are required changes on the theme ❌.

❎ REQUIRED

  • Screenshot is wrong size! Detected: 1440x1080. Maximum allowed size is 1200x900px.
💡 RECOMMENDED (1)
  • Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.

epi: There are required changes on the theme ❌.

❎ REQUIRED

  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).

leancv: No changes required ✅.

⚠️ WARNING (1)
  • Found ="<?php esc_html_e(' src='<?php echo esc_url( get_styleshee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant