Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventual: remove static links #8539

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Eventual: remove static links #8539

wants to merge 1 commit into from

Conversation

dsas
Copy link
Contributor

@dsas dsas commented Dec 16, 2024

See #8252

Changes proposed in this Pull Request:

Related issue(s):

@github-actions GitHub Actions
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Eventual.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions GitHub Actions
Copy link
Contributor

Theme-Check results

eventual: No changes required ✅.

⚠️ WARNING (1)
  • assets/images/image-from-rawpixel-id-5922463_distorted.jpg is 821.1 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.

dsas
dsas commented Dec 16, 2024
View reviewed changes
eventual/patterns/index.php
Copy link
Contributor Author

@dsas dsas Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intententionally removed @alaczek ? As far as I can tell it's hidden and unused, but just wanted to double check.

Change looks fine to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies, I should have communicated this clearly - yes, this has been my conclusion as well and reason for removing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaczek alaczek alaczek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsas @alaczek