-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rainfall: Add paddings and other visual theme improvements #8551
base: trunk
Are you sure you want to change the base?
Conversation
Preview changesI've detected changes to the following themes in this PR: Rainfall. I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
@beafialho Thanks for the PR! The changes look good, but there seem to be extra side paddings around the title in the archive and the page with black header templates. Also, for some reason, the height of the spacers in this change seems broken. Example And Let me know if you need help with anything. |
Thanks for reviewing @iamtakashi! I submitted a fix for the spacer issues and the extra side paddings you pointed out. Regarding the navigation block, I can't find the But yes, CBT was supposed to handle that.. I don't understand why that's happening because I clicked in this option when I saved it: |
Correction: I spotted one ref in the footer part. Submitted a fix for that too! |
Theme-Check resultsrainfall: No changes required ✅. |
Thanks for the update, @beafialho. There are still broken spacers in There are some templates with images and text that need to be localised. Can you make sure the Localize Text and Images options are checked, and the Process Only Modified Templates option is unchecked the next time you save the theme? |
Rainfall is currently looking badly because it has no paddings on the site at all:
rainfall.mp4
I went ahead and fixed it, along with other visual improvements I thought should be done to the theme overall.
@iamtakashi when you have a moment, can you review these changes? Also, let me know if there's anyone else I should ask for a review. Thanks in advance.