BB8-11121: Prevent enabling debug mode on local env for logged out users

[aswasif007]

Description

We are updating the code to prevent debug mode from enabling automatically on local env for logged out users.

Changelog Description

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

• This change works and has been tested locally (or has an appropriate fallback).
• This change works and has been tested on a Go sandbox.
• This change has relevant unit tests (if applicable).
• This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
• This change has relevant documentation additions / updates (if applicable).
• I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

• VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

[aswasif007]

I am not sure if this has other implications. @Automattic/vip-platform-cantina please advise!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.58%. Comparing base (9709732) to head (ada81e0).
Report is 162 commits behind head on develop.

Files with missing lines	Patch %	Lines
000-debug/debug-mode.php	33.33%	4 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #5341      +/-   ##
=============================================
+ Coverage      29.57%   29.58%   +0.01%     
  Complexity      4780     4780              
=============================================
  Files            282      282              
  Lines          20600    20593       -7     
=============================================
+ Hits            6092     6093       +1     
+ Misses         14508    14500       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rebeccahum]

@aswasif007 Per the BB8 comments, we shouldn't be removing this entirely locally, but only forcing it for users logged in locally I think.

[github-actions]

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[rinatkhaziev]

Needs further consideration.

[github-actions]

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

[WPprodigy]

It's a handy feature to be able to get QM for logged out requests. I don't think we should take that away. But at the same time, I agree that we shouldn't start QM for logged out by default since that's not normal behavior.

Maybe should be this instead:

if ( $is_nocache && $is_debug && ( $is_proxied || $is_local ) ) {