Preflight Checks: Implement event tracking #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaurdan
commented
Apr 22, 2022
| @@ -31,7 +31,7 @@ | |||
| "command-line-usage": "^6.1.1", | |||
| "enquirer": "^2.3.6", | |||
| "execa": "^4.0.0", | |||
| "node-fetch": "^3.1.1", | |||
| "node-fetch": "^2.6.7", | |||
There was a problem hiding this comment.
Had to rollback node-fetch to the latest version of the previous major version (2) due to incompatibility with ES modules.
chriszarate
reviewed
Apr 22, 2022
chriszarate
reviewed
Apr 22, 2022
chriszarate
reviewed
Apr 22, 2022
| /** | ||
| * External dependencies | ||
| */ | ||
| import fetch from 'node-fetch'; |
There was a problem hiding this comment.
probably a good candidate for vip-go-node-internal once we figure it out as a package
chriszarate
reviewed
Apr 22, 2022
chriszarate
approved these changes
Apr 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to measure usage of the Preflight Checks, this PR implements Tracks to track analytics on the executed tests, using the event
vip_preflight_checks_finish.This implementation is very simplistic, and it's forked from the VIP CLI. It sends the following parameters with the event:
cli_version- version of the Preflight Checks CLInode_version- version of Node.js used to execute the CLIos_name- Operating Systemos_version- Operating system version/kernel versionport- Selected (or randomly generated) port used for the checksselected_node_version- Node.js version selected to run the checksverbose-true, if running in verbose modewait- selected wait timeis_success/is_failed/is_warning- boolean value that flag if checks succeeded, if there are any warnings, or if failed.Steps to Test
npm run build.cdto a VIP Go node site repositorynode [path-to-vip-go-node-repo]/preflight-checks/dist/index.js