Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request checks are failing after release of WordPress 6.1 #5042

Closed
aprea opened this issue Nov 3, 2022 · 0 comments · Fixed by #5049
Closed

Pull request checks are failing after release of WordPress 6.1 #5042

aprea opened this issue Nov 3, 2022 · 0 comments · Fixed by #5049
Labels
category: devops Features and tools supporting dev process. status: has pr The issue has a PR. type: bug The issue is a confirmed bug.

Comments

@aprea
Copy link
Contributor

aprea commented Nov 3, 2022

Describe the bug

The following pull request checks started failing shortly after the release of WordPress 6.1.

Example errors:

1) WC_REST_Payments_Settings_Controller_Test::test_get_settings_request_returns_status_code_200
Undefined property: WC_REST_Payments_Settings_Controller_Test::$mock_token_service

/home/runner/work/woocommerce-payments/woocommerce-payments/tests/unit/admin/test-class-wc-rest-payments-settings-controller.php:131
/home/runner/work/woocommerce-payments/woocommerce-payments/vendor/yoast/phpunit-polyfills/src/TestCases/TestCasePHPUnitGte8.php:56

2) WC_REST_Payments_Settings_Controller_Test::test_get_settings_returns_enabled_payment_method_ids
Undefined property: WC_REST_Payments_Settings_Controller_Test::$mock_token_service

/home/runner/work/woocommerce-payments/woocommerce-payments/tests/unit/admin/test-class-wc-rest-payments-settings-controller.php:131
/home/runner/work/woocommerce-payments/woocommerce-payments/vendor/yoast/phpunit-polyfills/src/TestCases/TestCasePHPUnitGte8.php:56

3) WC_REST_Payments_Settings_Controller_Test::test_get_settings_returns_available_payment_method_ids
Undefined property: WC_REST_Payments_Settings_Controller_Test::$mock_token_service

Example test failures:

1) WC_Payments_Webhook_Processing_Service_Test::test_payment_intent_successful_and_completes_order
Unexpected incorrect usage notice for WP_Object_Cache::delete.
Cache key must be integer or non-empty string, NULL given. (This message was added in version 6.1.0.)
Failed asserting that an array is empty.

/tmp/wordpress-tests-lib/includes/abstract-testcase.php:615
/tmp/wordpress-tests-lib/includes/abstract-testcase.php:627
/home/runner/work/woocommerce-payments/woocommerce-payments/vendor/yoast/phpunit-polyfills/src/TestCases/TestCasePHPUnitGte8.php:80

2) WC_Payments_Webhook_Processing_Service_Test::test_payment_intent_successful_and_completes_order_without_intent_id
Unexpected incorrect usage notice for WP_Object_Cache::delete.
Cache key must be integer or non-empty string, NULL given. (This message was added in version 6.1.0.)
Failed asserting that an array is empty.

/tmp/wordpress-tests-lib/includes/abstract-testcase.php:615
/tmp/wordpress-tests-lib/includes/abstract-testcase.php:627
/home/runner/work/woocommerce-payments/woocommerce-payments/vendor/yoast/phpunit-polyfills/src/TestCases/TestCasePHPUnitGte8.php:80

3) WC_Payments_Webhook_Processing_Service_Test::test_payment_intent_successful_when_retrying
Unexpected incorrect usage notice for WP_Object_Cache::delete.
Cache key must be integer or non-empty string, NULL given. (This message was added in version 6.1.0.)
Failed asserting that an array is empty.

/tmp/wordpress-tests-lib/includes/abstract-testcase.php:615
/tmp/wordpress-tests-lib/includes/abstract-testcase.php:627
/home/runner/work/woocommerce-payments/woocommerce-payments/vendor/yoast/phpunit-polyfills/src/TestCases/TestCasePHPUnitGte8.php:80

To Reproduce

  1. Branch off develop.
  2. Commit some code.
  3. Push your changes.
  4. Create a pull request.
  5. Observe the compatibility, code coverage and PHP linting and tests pull request checks fail.

Actual behavior

Pull request checks fail when testing against WordPress 6.1.

Screenshots

Screen Shot 2022-11-03 at 3 00 46 pm

Expected behavior

Pull request checks pass as expected when testing against WordPress 6.1.

Additional context

Discussed in Slack here p1667353741152329-slack-CGGCLBN58

@aprea aprea added type: bug The issue is a confirmed bug. category: devops Features and tools supporting dev process. labels Nov 3, 2022
@aprea aprea changed the title Pull request checks are failing after the WordPress 6.1 release Pull request checks are failing after release of WordPress 6.1 Nov 3, 2022
@deepakpathania deepakpathania added the status: has pr The issue has a PR. label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: devops Features and tools supporting dev process. status: has pr The issue has a PR. type: bug The issue is a confirmed bug.
Projects
None yet
2 participants