Pin WordPress to 6.0.3 for pull request checks. #5043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 999 kB ℹ️ View Unchanged
|
Jinksi
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
This seems a sensible temporary fix to me, unblocking us within the current release code freeze.
As you mentioned in the Slack discussion, e2e tests are still passing on WC 6.1, giving us confidence that critical flows are working. p1667353741152329-slack-CGGCLBN58
Ideally, we can update these failing tests to work with WC 6.1 before the 5.0.0 release.
Update: it looks like this is in progress already 🎉 #5049
|
Closing in favor of #5049, which simply fixed the issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5042
Changes proposed in this Pull Request
This PR pins WordPress to 6.0.3 for the compatibility, code coverage and PHP linting and tests pull request checks.
Testing instructions
develop.)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge