-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add badge icon to the Uncaptured tab in Transactions page #5180
Comments
Update: The components should be evaluated to see if the recommended one is production-ready. |
I had a look at the In my opinion, it's too early to start using this component and we should wait until a more stable version is consolidated. |
After discussing with the team we decided to close the issue since the suggested FYI: @bradyv since you were involved in the original discussion. |
@elizaan36, @vbelolapotkov: you are likely the right people to ask. In the context of updating UI/UX components, we have two factors: updating dependencies and experimental components. Who are the right people to own and move forward with the related initiatives (example issues)?:
It feels like a waste of a good initiative, and if you have pointers to an umbrella ticket we'll link the closed ones. |
hey @kalessil thanks for reaching out about these issues. We do need to focus on making these UI improvements holistically on Payments tables, and there's an initiative to redesign the UI to be more in line with the future state of the WordPress admin. @rogermattic has been taking a close look at this in relation to reporting and we should have more to share soon! |
@kalessil just the heads up that those three issues are on my radar now and I will report back when I have some more context to share! |
Sounds good @rogermattic ! |
Description
The number of transactions in the Uncaptured tab should be displayed inside a badge icon
Acceptance criteria
Designs
Dev notes
The TabPanel component that we used to implement the first iteration does not support passing an icon, only text. We need to find a way to pass the icon using the same component, or use a different component. Check additional context section.
Additional context
P2:
paJDYF-4N1-p2#comment-14875
paJDYF-4N1-p2#comment-14930
The text was updated successfully, but these errors were encountered: