-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed order email has incorrect payment method title #9779
Comments
For posterity, I added some insight here: #9647 (comment) I was trying to find a different approach to implement in the if ( did_action( 'woocommerce_email_header' ) ) {
return $title;
} But that didn't seem to work. The payment method from the email is retrieved from the order, and it is set via the It looks like we might need to revisit the implementation of the "Test mode" badge on the shortcode checkout. In the meantime, I added this filter that will land in WooPayments 8.6.0: #9783 A workaround to this issue with email templates could be achieved with the following code, using the filter mentioned in the previous paragraph: add_filter( 'wcpay_checkout_use_plain_method_label', 'is_ajax' ); |
CCing @pierorocca & @FangedParakeet on the above comment as well ☝ |
I'll catch up with you on DM to better understand how the badge is associated with the payment method label. |
There is a report on this in 8658095-zen where Kadence WooCommerce Email Designer (a 3pd plugin) is displaying something similar. Here is a screenshot of what the customers see: And a preview of the email, on the customizer plugin: cc. @frosso as discussed via DM |
@morepurplemorebetter thank you again for the discussion and for logging the ticket! We'll bring it back in a safer way in a future release. Thanks for your patience! |
@frosso thank you for taking the time to fix this issue and responding so kindly. |
#9073954-zen This is in the email as well as the order list page:
|
Describe the bug
Since #9647 was merged, the order confirmation emails include added content for the payment method title, which shouldn't be there.
To Reproduce
[woocommerce_checkout]
.Screenshots
This is how the relevant part of an email for a test purchase on my staging environment looks now.
Additional context
It seems that
is_checkout()
here here is returningtrue
because the email is being sent from the checkout page. Perhaps an extra check can be added to prevent this happening for emails?The text was updated successfully, but these errors were encountered: