fix: remove 'test mode' badge from shortcode checkout #9800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -531 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
frosso
requested review from
a team and
brettshumaker
and removed request for
a team
timur27
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Thanks @frosso!
Block-based checkout is indeed unaltered ✅
Shortcode doesn't add labels to payment gateway radio inputs anymore ✅
Screen.Recording.2024-11-25.at.12.10.39.mov
Email content is correct (the below screenshot comes from the purchase with the shortcode checkout) ✅
frosso
added a commit
that referenced
this pull request
Nov 25, 2024
jaclync
added a commit
that referenced
this pull request
Nov 27, 2024
* develop: Wait for Stripe js to load before using it (#9770) Remove redundant stripe payment elements mount for pay for order (#9813) Enforce proper return types for methods get_order_from_event_body (#9761) Update phpcompatibility to develop version to get sniffs for PHP 8 (#9697) Enable ECE Tracks Events when WooPay is disabled (#9793) chore: rename PRB constants to ECE (#9768) Amend changelog entries for release 8.5.1 fix: remove 'test mode' badge from shortcode checkout (#9800) Update version and add changelog entries for release 8.5.1
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9779
Changes proposed in this Pull Request
It has been noted that the way the "test mode" badge is applied on shortcode is breaking some sites email templates and possibly causing incompatibility with some other plugins.
Reverting all the changes to the "test mode" badge in shortcode.
We'll need to find a different solution than to change the
get_title()method on the card gateway.Reverting changes to these files:
client/checkout/classic/event-handlers.jsclient/checkout/classic/style.scssincludes/class-wc-payment-gateway-wcpay.phptests/e2e-pw/specs/shopper/klarna-checkout-purchase.spec.tsI cherry-picked the changes from these PRs:
get_title()method to add the "Test mode" badgeget_title()method aboveget_title()method to add additional markup and make the "test mode" badge appear only when the payment method was selected on the checkout pageTesting instructions
E2E tests run: https://github.com/Automattic/woocommerce-payments/actions/runs/12007054058
Failures seem similar to the ones on
develop.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge