Enable ECE Tracks Events when WooPay is disabled #9793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
rafaelzaleski
requested review from
a team and
reykjalin
and removed request for
a team
reykjalin
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Tests well and looks good!
Unrelated to this PR and the issue it's solving: I did run into an issue where Apple Pay button load events aren't being triggered because of how triggering the tracks event is debounced.
The onReadyHandler is triggered separately for the APay and GPay buttons so trackExpressCheckoutButtonLoad is called twice with different arguments each time. This means the second call is debounced and not sent.
|
Thank you, @reykjalin! I’ll start working on the debounce issue next. |
jaclync
added a commit
that referenced
this pull request
Nov 27, 2024
* develop: Wait for Stripe js to load before using it (#9770) Remove redundant stripe payment elements mount for pay for order (#9813) Enforce proper return types for methods get_order_from_event_body (#9761) Update phpcompatibility to develop version to get sniffs for PHP 8 (#9697) Enable ECE Tracks Events when WooPay is disabled (#9793) chore: rename PRB constants to ECE (#9768) Amend changelog entries for release 8.5.1 fix: remove 'test mode' badge from shortcode checkout (#9800) Update version and add changelog entries for release 8.5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9784
Changes proposed in this Pull Request
This PR addresses the issue where ECE Tracks Events are not being enabled when WooPay is disabled. By implementing this change, event tracking remains functional irrespective of the WooPay payment gateway’s status, ensuring consistent data collection and analytics.
Testing instructions
Prepare Environment:
Disable WooPay:
Set Breakpoint:
class-woopay-tracker.phpand add a debugger breakpoint at line 327.Trigger Events and Verify Event Recording:
wcpay_applepay_button_loadandwcpay_gpay_button_loadare being recorded as expected.Verify that the issue existed:
developbranch to the same environment.developand fixed in this branch.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge