fix: payment method icon alt text #9648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
frosso
requested review from
a team and
brettshumaker
and removed request for
a team
frosso
added
the
size: x-small
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
frosso
commented
Oct 30, 2024
| @@ -3222,12 +3222,18 @@ public function update_fraud_rules_based_on_general_options() { | |||
| } | |||
|
|
|||
| /** | |||
| * The get_icon() method from the WC_Payment_Gateway class wraps the icon URL into a prepared HTML element, but there are situations when this | |||
There was a problem hiding this comment.
Discussed during team meeting - it looks like this is no longer applicable.
brettshumaker
approved these changes
Oct 30, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request
While working on #9625 , I noticed that the
alttext on the payment method icon displayed at checkout contains some undesired markup.Before:
After:
Testing instructions
cardpayment method's iconalttext should no longer contain markup, it should instead beCredit card / debit card payment method logoalttag, because I think it's more descriptive 🤷altattribute for the other WooPayments payment method icons at checkoutnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge