Omit Test Mode badge in the Change payment method form #9615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +116 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
danielmx-dev
requested review from
cesarcosta99,
a team and
brettshumaker
and removed request for
a team
danielmx-dev
commented
Oct 22, 2024
Comment on lines
+42
to
+43
| &.wc_payment_methods, | ||
| &.woocommerce-PaymentMethods { |
There was a problem hiding this comment.
The diff is a bit messy, but these are the only new selectors that were added, to prevent these styles to be applied in the change payment method form.
mdmoore
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
I can verify that this fixes the HTML output on the Woo Subscriptions Change Payment Method page and omits the Test Mode badge there. I've tested all the changes from #9495, and everything is still working as expected without any regressions.
danielmx-dev
deleted the
fix/omit-test-mode-badge-in-change-payment-form
branch
cesarcosta99
pushed a commit
that referenced
this pull request
Oct 23, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9616
Related to #9495
Changes proposed in this Pull Request
In order to show the "Test mode" badge, we need to insert HTML into the payment method title when rendering the form. This isn't a problem for WooCommerce core since the contents of
get_titleare not escaped. See: https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/templates/checkout/payment-method.php#L26However; WooCommerce Subscriptions recreates the code to render the form, but the plugin does escape the HTML, causing the HTML to be rendered as text. See: https://github.com/Automattic/woocommerce-subscriptions-core/blob/trunk/templates/checkout/form-change-payment-method.php#L70C81-L70C119
Testing instructions
Before
After
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge