-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payouts: Show Bank Reference Key on Payout details page. #9878
Comments
This seems like an obviously-useful enhancement to me, I think we can prioritise for maintenance. Next steps:
I removed |
Moving back to |
Hey @nagpai @haszari !
I was thinking we could add a dedicated section for this on the page. For instance, the Payouts page could share the same template as a Transaction Single. In that case, we could use the "details" box from the Transaction Single page for consistency. I made a quick mockup to show how this might look on the Payout Details page (still a work in progress, but I wanted to run it past you first to see if it’s worth exploring further). The Payout details box could be at the bottom of the page, if we could add a max height + pagination to the table: Or otherwise just above the table so it isn't easy to miss: Overall, I believe this approach is more future-proof. The closer the single pages (e.g., payment and payout) are in structure, the better. Ideally, they could share a template so that any future improvements to these components would automatically apply across all instances, ensuring a consistent and predictable design. What do you think? We could further align the single pages as a separate scope. |
@rogermattic - Thanks! The approach you have suggested is certainly more scalable, and frees us from the pitfall of cluttering the main header. Between the two screenshots you've shared, I prefer the details to be shown on top ( option 2 ). This is because the merchant would want to copy the reference ID in case they wish to send it to their bank on an email e.t.c. Tagging @souravdebnath1986 and @aheckler for your views 🙌🏼 |
Also prefer the payout details on top. Looks good! |
Thanks @rogermattic 🙌 Slight preference for details at bottom for me – don't want to push the table of payout details down too far. But either layout works, and this is definitely an improvement. As well as decluttering the header visually, there is some complex code to manage all the different content for the header (instant payouts, negative payouts have subtle differences). This clean layout will help us simplify the code too 🚀 |
Great! Thanks for your feedback! Is there any other detail or information we could display there? Personally, I slightly prefer placing it at the bottom since it’s additional information. However, I noticed that the table can get quite long, and since users currently don’t expect anything else on the page—and the table doesn’t include pagination (?)—placing it at the top might be a better option. I’ll finalize the designs tomorrow and share the updated version here! :) |
Hey @nagpai @haszari @aheckler I’ve created the mockups and some basic flows—let me know if I missed anything! Here’s what I’ve updated:
Would you mind helping me brainstorm reasons (or any additional information) we could display to the user if the bank reference is unavailable? By the way,
This is still a valid question if anyone has any feedback / ideas. |
Looks good @rogermattic !
I think this is overcomplicating things (also hover is not a thing on mobile). Could we just show the copy icon at all times? And if you tap/click the ID or the label or the button, it copies 🎉 with light feedback e.g. green or checkmark icon or similar.
I don't know if it's worthwhile having a tooltip here, it's a low-importance thing so maybe don't need the clutter. If we get a lot of feedback then we can add a tooltip later. I think we can just use @nagpai curious – is there another copy button in the UI somewhere (that you used as a model for the PR)? I thought this would be on payment details page for payment ID, but it's not copiable. @rogermattic are you aware of other copiable IDs like this elsewhere in the UI? Maybe we could make a component for this. |
I picked up hints from a copy button that was recently introduced in checkout on the front end. I was unable to find any copy button in the admin though. I have created a copy button component in my linked PR which should be reusable for any long ID's that are often copied by merchants.
I agree. Here is how it looks currently with the copy-button component @rogermattic YROMR4.mp4 |
@rogermattic - Can you share a mockup on how this would appear on a desktop screen ( would that be 1920 wide ? ) and a mobile / narrow tablet screen? I did a quick test and found the following issue:
|
@rogermattic I played a bit with CSS and managed to get this. Let me know what you think. I will also share a test site with you. 111-Screen.Capture.on.2024-12-20.at.13-26-12.mp4 |
Description
We recently added a
Bank reference key
column on the Payouts list report page and it's CSV exports. - #9832We need to now show the Bank reference key in the Payout details page.
Acceptance criteria
The
Bank reference key
of a payout should be visible on its details page.Designs
We will need help from design to figure out the best place to show the reference number. Based on documents from banks etc, the length of the key is not more than 40 characters. But the key that is included in test payout objects show upto 41 characters in length.
Here are some sample keys and patterns I have spotted in last 50 payouts in the server DB:
A very rough mockup of how this looks with 41 characters, if we were to add it below the existing header
Additional context
The text was updated successfully, but these errors were encountered: