Payouts: Add payout bank reference key to payout reports and CSV #9832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +57 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
brucealdridge
approved these changes
Nov 29, 2024
client/deposits/list/index.tsx
Outdated
Comment on lines
102
to
103
| label: __( 'Trace ID', 'woocommerce-payments' ), | ||
| screenReaderLabel: __( 'Trace ID', 'woocommerce-payments' ), |
There was a problem hiding this comment.
We should consider changing this to something that is clearer to Merchants such as Reference
nagpai
added
status: blocked
|
Marking as blocked until the required server-side PR is merged. |
nagpai
changed the title
nagpai
added
pr: ready to merge
and removed
status: blocked
|
Merging this PR slightly before the server, after making sure it does not break anything - other than showing Merging it early so that it can catch the 8.6.0 release. Discussed here: p1732879431882379-slack-CGGCLBN58 |
jaclync
added a commit
that referenced
this pull request
Dec 2, 2024
* develop: Ensure ECE button load events are triggered for multiple buttons on the same page (#9845) Payouts: Add payout bank reference key to payout reports and CSV (#9832) Fix WooPay component spacing (#9748) Use paragraph selector instead of label for pmme appearance (#9840) Allow redirect to the settings page from WCPay connect (#9827) Update references to woocommerce_payments_server (#9824) Fix return types in DocBlocks (#9815) Fix WooPay trial subscriptions purchases (#9778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5316
Note
Note added after PR approval - for future reference -
Trace IDwas renamed toBank reference key, based on review feedback and p1732861507747189/1732857021.096589-slack-C02BW3Z8SHK. If you spot trace ID anywhere in the discussion below ( other than Stripe Payout object ), please read it asBank reference keyChanges proposed in this Pull Request
Trace IDcolumn in payouts list seen withinPayments > Payouts, and within CSV exports. TheTrace IDwill help merchants match inbound payout entries in their bank statements with WooPayments Payouts.Testing instructions
add/6838-payout-trace-id, unless it is already merged.npm run down && npm run upon the server to restart docker and make sure thetrace_idcolumn is added to the payouts cache tables.acct_1OuYn1QpUShfetUAif you like, since that account has a few sample payouts that can be helpful for testing.Payments > DepositsTrace IDcolumn and the ID on the payouts after November 21, 2024.Test browser export
Test endpoint export
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge