Fix WooPay component spacing #9748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alefesouza
requested review from
a team and
hsingyuc
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -1.05 kB (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
hsingyuc
reviewed
Nov 20, 2024
There was a problem hiding this comment.
@alefesouza correct me if I am wrong. I noticed if we remove below mentioned code can fix the styling. Let me know what do you think.
- It seems we have extra line added here.
- Remove these code will get the line back for payment options.
-
Remove margin from
#remember-mefor @media<600 solves theAdd a note to your ordertop gap issue -
Remove this and this margin removes the gap above
Add a note to your order.
Recording of remove above mentioned code, WooPay enabled, Blocks seperator disabled:
remove.code.separator.disabled.woopay.enabled.mov
cc @pierorocca
hsingyuc
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Thank you for double-checking!
I see you revert this PR here, and I believe .without-margin-right is no longer needed from here and here. This styling seems redundant if we have only one checkbox under wc-block-components-checkbox.
hsingyuc
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
@alefesouza Thank you for the fixes! I tested again and looking good to me. 👍
jaclync
added a commit
that referenced
this pull request
Dec 2, 2024
* develop: Ensure ECE button load events are triggered for multiple buttons on the same page (#9845) Payouts: Add payout bank reference key to payout reports and CSV (#9832) Fix WooPay component spacing (#9748) Use paragraph selector instead of label for pmme appearance (#9840) Allow redirect to the settings page from WCPay connect (#9827) Update references to woocommerce_payments_server (#9824) Fix return types in DocBlocks (#9815) Fix WooPay trial subscriptions purchases (#9778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9699
Changes proposed in this Pull Request
This PR fixes the WooPay component spacing and border issues on mobile.
Testing instructions
Test on desktop and mobile viewports.
Save my infoshould be shownSave my infocomponent should be hiddennpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge