Fix return types in DocBlocks #9815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
mgascam
changed the title
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
dmvrtx
approved these changes
Nov 27, 2024
jaclync
added a commit
that referenced
this pull request
Dec 2, 2024
* develop: Ensure ECE button load events are triggered for multiple buttons on the same page (#9845) Payouts: Add payout bank reference key to payout reports and CSV (#9832) Fix WooPay component spacing (#9748) Use paragraph selector instead of label for pmme appearance (#9840) Allow redirect to the settings page from WCPay connect (#9827) Update references to woocommerce_payments_server (#9824) Fix return types in DocBlocks (#9815) Fix WooPay trial subscriptions purchases (#9778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4293
Changes proposed in this Pull Request
This pull request includes changes to the DocBlock return types of multiple methods across various files in the
includesdirectory. I noticed these issues while working on #4293Return type corrections:
includes/admin/class-wc-rest-payments-customer-controller.php: Updated the return type ofprepare_item_for_responseto remove the redundantWP_REST_Response.includes/admin/class-wc-rest-payments-onboarding-controller.php: Updated the return type offinalize_embedded_kycto remove the redundantWP_HTTP_Response.includes/admin/class-wc-rest-payments-payment-intents-create-controller.php: Updated the return type ofprepare_item_for_responseto remove the redundantWP_REST_Response.includes/admin/class-wc-rest-payments-reader-controller.php: Updated the return type ofget_summaryto remove the redundantWP_HTTP_Response.includes/class-wc-payments-token-service.php: Simplified the return type ofadd_token_to_userto only includeWC_Payment_Token.includes/reports/class-wc-rest-payments-reports-authorizations-controller.php: Updated the return type ofprepare_item_for_responseto remove the redundantWP_REST_Response.includes/reports/class-wc-rest-payments-reports-transactions-controller.php: Updated the return type ofprepare_item_for_responseto remove the redundantWP_REST_Response.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge