-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce API impact from test drive setup #10014
Reduce API impact from test drive setup #10014
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +22 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
Tested and works as described in the testing instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code changes are looking good!
✅ Manually tested with US and DE and all tests are successful.
Contributes to https://github.com/Automattic/transact-platform-server/issues/6837
Changes proposed in this Pull Request
To help reduce the potential impact of the test-drive setup process that checks the account status in a loop:
Testing instructions
npm run build
trunk
. Do NOT listen for webhooks.sleep(3);
line at the beginning of theWC_REST_Payments_Accounts_Controller::get_account_data()
method to simulate a slow response from the backend.npm run listen
Complete
account status on the Payments Overview page:npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge