Upgrade @woocommerce/csv-export to v1.10.0 – fixes unnecessary escaping of negative values in CSV exports
#10028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unnecessary escaping of negative values in CSV exports that was preventing numerical analysis in spreadsheet applications
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
shendy-a8c
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9303
Changes proposed in this Pull Request
This PR upgrades the
@woocommerce/csv-exportpackage to v1.10.0 (npm).This fixes unnecessary escaping of negative values in CSV exports that was preventing numerical analysis in spreadsheet applications.
Important
I discovered in this PR that the
csv-exportpackage version used by WooCommerce core (wp-content/plugins/woocommerce/assets/client/admin/csv-export/index.js) overrides the version imported into WooPayments.Therefore, this fix will only work when using WC 9.6+ (currently pre-release).
Testing instructions
csv-exportversion inwp-content/plugins/woocommerce/assets/client/admin/csv-export/index.jswill override the version imported intoWooPayments.WP-Admin → Payments → Transactionson a WooPayments account that doesn't have many transactions (you can use the advanced filters in the "show" dropdown if the account has many transactions to reduce the number of transactions shown to ~20 or so)'character.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.@woocommerce/csv-exportare sufficientPost merge