-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused useEffect import to fix GH linter warning #10035
Remove unused useEffect import to fix GH linter warning #10035
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are straightforward and removes the unwanted declaration. This will also prevent the linter warning. Good to merge!
Fixes #10034
Changes proposed in this Pull Request
This is a cleanup PR – simply removes an unused
useEffect
import that was causing a linter warning to appear on all PRs in the files tab.PR to see example of warning: https://github.com/Automattic/woocommerce-payments/pull/10030/files.
This is a preview GH feature, so you may need to enable it in your GH user settings to see the warning, unless it is enabled repo-wide (unsure).
Testing instructions
I've confirmed that this PR fixes the warning:
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge