Fix amounts when manually renewing a subscription #10156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
cesarcosta99
requested review from
a team and
asumaran
and removed request for
a team
asumaran
requested changes
Jan 17, 2025
There was a problem hiding this comment.
The code looks good and works as expected. I’m leaving a small comment, but it doesn’t require any major changes.
Great fix, @cesarcosta99!
tests/unit/multi-currency/compatibility/test-class-woocommerce-subscriptions.php
Outdated
Show resolved
Hide resolved
asumaran
approved these changes
Jan 20, 2025
leonardola
pushed a commit
that referenced
this pull request
Jan 28, 2025
dmvrtx
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6739.
Changes proposed in this Pull Request
This PR tweaks the
should_convert_product_pricelogic in the WooCommerce Subscriptions multi-currency compatibility. The implementation of the method is changed in a way to separate the subscription renewal logic from the resubscribe logic since they can behave differently.This fixes the "mini-cart" unconverted amount issue reported in #6739 and makes sure the amount is converted as needed in other places. "Mini-cart" is within quotes because the issue is not in the mini-cart, actually it's in the subtotal value that was not being converted on time for display.
Testing instructions
Setup
Important
During testing, pay close attention to amounts all of the time. This way we can ensure a consistent conversion and behavior of all multi-currency and subscriptions interactions.
Test: Ensure all amounts are displayed correctly when doing an early renewal
Regression test: Ensure purchasing a simple subscription works as expected
Regression test: Ensure automatic subscription renewal works as expected
woocommerce_scheduled_subscription_paymentitem with the customer subscription ID.Regression test: Ensure merchant manual subscription renewal works as expected
Regression test: Ensure resubscribe works as expected
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge