Convert shopper purchasing multiple subscriptions E2E test to Playwright #10170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bscriptions-purchase-multiple
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
…bscriptions-purchase-multiple
allie500
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Thanks for working on this Taha. I've left one nitpick. Other than that, the code looks good. However, the test fails on my local in both headless and UI mode at the last step due to the multi-currency issue. I can see that the tests are passing on GH Actions which is great.
Let's huddle up on this tomorrow when we are both on to see if we can get to the bottom of the issue.
| describeif( shouldRunSubscriptionsTests )( | ||
| 'Subscriptions > Purchase multiple subscriptions', | ||
| () => { | ||
| let merchantPage, shopperPage: Page; |
There was a problem hiding this comment.
Nitpick: I think we should change this to:
let merchantPage: Page, shopperPage: Page;
Otherwise I'm seeing that merchantPage implicitly has an any type.
There was a problem hiding this comment.
Yep, that's right, thanks for catching it!
There was a problem hiding this comment.
Added it in b038179.
allie500
approved these changes
Jan 21, 2025
tpaksu
deleted the
dev/10087-playwright-migration-shopper-subscriptions-purchase-multiple
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10087
Changes proposed in this Pull Request
This PR adds a new E2E test focusing on shopper purchasing multiple subscriptions using Playwright, and removes the existing one from Puppeteer.
Testing instructions
npm run test:e2e-pw shopper-subscriptions-purchase-multiplenpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge