Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Shopper Checkout Purchase spec to Playwright #10198

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

ismaeldcom
Copy link
Contributor

@ismaeldcom ismaeldcom commented Jan 20, 2025

Fixes #10065

Changes proposed in this Pull Request

Convert the shopper-checkout-purchase spec from Puppeteer to Playwright.

This PR includes a copy of expectFraudPreventionToken already implemented in a previous PR.

Testing instructions

  • Checkout dev/10177-convert-shopper-checkout-purchase-spec
  • Run npm run test:e2e-pw shopper-checkout-purchase
  • Test should pass locally.
  • Test should pass in GH actions.

  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@ismaeldcom ismaeldcom self-assigned this Jan 20, 2025
@botwoo

This comment was marked as off-topic.

This comment was marked as off-topic.

@ismaeldcom ismaeldcom requested a review from a team January 20, 2025 11:09
Copy link
Contributor

@tpaksu tpaksu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is understandable and clean, tests well both on local and remote, LGTM. :shipit: !

@tpaksu tpaksu linked an issue Jan 21, 2025 that may be closed by this pull request
@tpaksu
Copy link
Contributor

tpaksu commented Jan 21, 2025

@ismaeldcom I think this will close 10065, not 10177 btw. Correct?

@ismaeldcom
Copy link
Contributor Author

ismaeldcom commented Jan 21, 2025

True! nice catch, I messed it up while copying the other PR ID for the existing code reference 😅

@ismaeldcom ismaeldcom added this pull request to the merge queue Jan 21, 2025
@ismaeldcom ismaeldcom removed this pull request from the merge queue due to a manual request Jan 21, 2025
@ismaeldcom ismaeldcom added this pull request to the merge queue Jan 22, 2025
Merged via the queue into develop with commit 7e2db04 Jan 22, 2025
25 checks passed
@ismaeldcom ismaeldcom deleted the dev/10177-convert-shopper-checkout-purchase-spec branch January 22, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Playwright Migration: convert shopper-checkout-purchase spec
3 participants