Convert shopper checkout save card and purchase test to Playwright #10208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
…eckout-save-card-and-purchase
allie500
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks for working on this one, Taha. The code looks great. Tests are passing locally and in GH actions. The new Playwright spec is covering all the tests that the old Puppeteer spect covered.
I found a typo in one of the test name strings. I mentioned it inline. Once that is updated, it will be good to ship.
Pre-approving.
tests/e2e-pw/specs/shopper/shopper-checkout-save-card-and-purchase.spec.ts
Outdated
Show resolved
Hide resolved
tpaksu
deleted the
dev/10066-playwright-migration-shopper-checkout-save-card-and-purchase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10066
Changes proposed in this Pull Request
This PR converts the shopper checkout save card and purchase E2E test to Playwright and deletes the Puppeteer one.
Testing instructions
npm run test:e2e-pw save-card-and-purchaseand expect the tests to succeed.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge