Construct table summary data only when transactions and deposits summary data has been loaded. #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naman03malhotra
force-pushed
the
fix/1639-transaction-deposit-count
branch
from
1a94f93 to
6c152b6
Compare
naman03malhotra
changed the title
naman03malhotra
changed the title
naman03malhotra
force-pushed
the
fix/1639-transaction-deposit-count
branch
from
301c711 to
1d6fd97
Compare
naman03malhotra
force-pushed
the
fix/1639-transaction-deposit-count
branch
2 times, most recently
from
e5defe7 to
fd9c53c
Compare
naman03malhotra
commented
May 17, 2021
kalessil
requested changes
May 18, 2021
naman03malhotra
force-pushed
the
fix/1639-transaction-deposit-count
branch
from
05dba30 to
4836e89
Compare
naman03malhotra
force-pushed
the
fix/1639-transaction-deposit-count
branch
2 times, most recently
from
5078ef8 to
fb260af
Compare
!
- if transaction summary and depost summary data is loaded then only contruct summary array
- added tests for the table summary changes - for both desposts and transactions list - snapshot update
- restored use of isSummaryLoading for both deposits and transations page - added comment for better clarification for initializing summary as undefined
naman03malhotra
force-pushed
the
fix/1639-transaction-deposit-count
branch
from
fb260af to
518797e
Compare
ismaeldcom
pushed a commit
that referenced
this pull request
May 27, 2021
… summary data has been loaded. (#1788) - if transaction summary and deposit summary data is loaded then only construct the summary array. - added tests for the table summary changes for both deposits and transactions list. - snapshot update. - added changelog entry. - added a comment for better clarification for initializing summary as undefined.
ismaeldcom
pushed a commit
that referenced
this pull request
May 27, 2021
… summary data has been loaded. (#1788) - if transaction summary and deposit summary data is loaded then only construct the summary array. - added tests for the table summary changes for both deposits and transactions list. - snapshot update. - added changelog entry. - added a comment for better clarification for initializing summary as undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1639
Presently we render the number of transactions and deposits in the summary section of the respective tables. While the data is being fetched from the server the count is rendered as
undefined.isSummaryLoadingis set to false initially which leads to construction of an array with empty/falsy values.Changes proposed in this Pull Request
Testing instructions
fix/1639-transaction-deposit-count