Fix: Columns are misaligned on Payments->Deposits #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naman03malhotra
changed the title
naman03malhotra
force-pushed
the
fix/1719-desposit-col-alignment
branch
from
eea7bc6 to
c3360d5
Compare
|
Hey @naman03malhotra, looks much better now! Found a case on transactions listing related to currency conversion marker rendering (div with class converted-amount is getting added before the amount in the case): Would you please take a look into it? |
naman03malhotra
force-pushed
the
fix/1719-desposit-col-alignment
branch
from
ad1c17a to
5df0e93
Compare
!
|
@naman03malhotra: this PR is approved, great job here! Would you please rebase it, to ensure the failed tests are getting green? |
- override alignment for deposits list page - slight adjustment in transaction table header margin
- Aligned data with currency conversion marker
naman03malhotra
force-pushed
the
fix/1719-desposit-col-alignment
branch
from
8c6f2cc to
bbe9561
Compare
@kalessil looks like this \/ workflow is failing for other PRs as well, the fix is not yet in the develop branch. |
|
@naman03malhotra , oh I see now. Go ahead then! |
ismaeldcom
pushed a commit
that referenced
this pull request
May 27, 2021
* Fix: #1719 Misaligned columns on Payments->Deposits - override alignment for deposits list page. - slight adjustment in transaction table header margin. - changelog update. - updated failing snapshots. - Review changes. - Aligned data with currency conversion marker.
ismaeldcom
pushed a commit
that referenced
this pull request
May 27, 2021
* Fix: #1719 Misaligned columns on Payments->Deposits - override alignment for deposits list page. - slight adjustment in transaction table header margin. - changelog update. - updated failing snapshots. - Review changes. - Aligned data with currency conversion marker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1719 (comment)
I had to reopen #1719 as GlobalStep observed misalignment on the deposits page as per the above comment.
Changes proposed in this Pull Request
After fix:
Testing instructions
fix/1719-desposit-col-alignment