Fix fatal error if store currency is changed after enabled currencies are set #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set, update tests.
jessepearson
added
the
component: customer multi-currency
… set, update tests.
luizreis
approved these changes
Jun 8, 2021
once they're addressed 🚀
Comment on lines
+265
to
267
| if ( ! isset( $available_currencies[ $code ] ) ) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Would you mind adding a test for this change? Something like this would be enough:
public function test_enabled_but_unavailable_currencies_are_skipped() {
update_option( 'wcpay_multi_currency_enabled_currencies', [ 'RANDOM_CURRENCY', 'USD' ] );
// Recreate Multi_Currency instance to use the recently set currencies.
$this->reset_multi_currency_instance();
$this->multi_currency = WCPay\Multi_Currency\Multi_Currency::instance();
$this->assertSame( [ 'USD' ], array_keys( $this->multi_currency->get_enabled_currencies() ) );
}
There was a problem hiding this comment.
Done in b9a7c71 , thanks for the example, I applied it directly 😁
| @@ -87,8 +92,6 @@ function () { | |||
| } | |||
|
|
|||
| public function test_get_enabled_currencies_returns_correctly() { | |||
| update_option( 'wcpay_multi_currency_enabled_currencies', $this->mock_enabled_currencies ); | |||
There was a problem hiding this comment.
Now that the options are defined during the test's setUp, could we remove the Multi_Currency instance reset from this test?
There was a problem hiding this comment.
Good catch, I missed that. Updated in b9a7c71
This was referenced Jun 8, 2021
jessepearson
added a commit
that referenced
this pull request
Jun 8, 2021
* Added phpunit tests for Customer Multi-Currency. * Fix fatal error if store currency is changed after enabled currencies are set (#2078) * Fix fatal error if store currency is changed after enabled currencies set, update tests. * Fix fatal error if store currency is changed after enabled currencies set, update tests. * Additional test for multi-currency, clean up of other tests.
moon0326
pushed a commit
that referenced
this pull request
Jun 16, 2021
* Added phpunit tests for Customer Multi-Currency. * Fix fatal error if store currency is changed after enabled currencies are set (#2078) * Fix fatal error if store currency is changed after enabled currencies set, update tests. * Fix fatal error if store currency is changed after enabled currencies set, update tests. * Additional test for multi-currency, clean up of other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2068 #2004
Changes proposed in this Pull Request
Testing instructions