Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report E2E test failures to Slack again #2347

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dechov
Copy link
Contributor

@dechov dechov commented Jul 2, 2021

Changes proposed in this Pull Request

Give E2E testing workflow access to environment variables necessary for reporting failures to Slack (with screenshots).

cc @kalessil (particularly in case omitting these variables was intentional)

Testing instructions

Added a temporary commit (7f7dde2) to trigger a failure and verify report in Slack – will reset/revert before merge.


  • Added changelog entry (or does not apply)
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

@dechov
Copy link
Contributor Author

dechov commented Jul 2, 2021

Doesn't look like it was reported 🤔

Edit: ah, "channel not found" error. Not sure what the current E2E_SLACK_CHANNEL value is, but if it's the name, it might not work, since it looks like it needs to be the ID [source, doc]. Will change it and retry. Still doesn't work.

@dechov dechov added the category: e2e Issues and PRs related to e2e tests. label Jul 3, 2021
@dechov
Copy link
Contributor Author

dechov commented Jul 3, 2021

Ah, it works now: it uses the E2E_CHANNEL_NAME variable after all – I need not have doubted the README 😄

I've committed that one to the workflow and added it to the repository secrets in GH, but there are some issues with the reporting that we should solve before going forward with this PR: much of the output is blank because the Automattic/puppeteer-utils library assumes Travis is being used.

@v18 v18 added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Jul 9, 2021
@dechov
Copy link
Contributor Author

dechov commented Jul 9, 2021

Should likely switch to using Slack reporting from WC core E2E utils instead. Discussion in p1625275687050700-slack-C026J0AL8NS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: e2e Issues and PRs related to e2e tests. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants