Initialize payment form on Pay for Order screen #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contexts where the updated_checkout event doesn't fire, the payment element isn't being mounted. Adds an explicit condition for doing so.
|
Looks good, tests well. I wasn't able to get the payment working though, looks like we'll need to add this processing to the pay for order page as well. The Stripe gateway does this by abstracting out the "form" we're working with a little bit, following the same pattern here seems sensible. Do we want to get this merged and open another issue? Or handle it here? I'm happy either way. |
|
Ah, right – thanks for testing that. I'm happy either way too – it might not be too complicated and it doesn't help much to make it look like it'll work when it won't, but I opened another issue (#293) so that I'm not a blocker for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contexts where the
updated_checkoutevent doesn't fire, the payment form isn't being rendered.This change adds an explicit condition for mounting the element, adapted from the Stripe extension (and looking ahead to when saved cards are supported, see #14).
Changes proposed in this Pull Request
masterTesting instructions
From an Edit Order admin screen for an order with "Pending payment" status, follow the link to the "Customer payment page →", and attempt to enter a credit card using this payment method.