Show currency switcher notice until customer explicitly dismisses it #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…switcher-customer-notice-does-not-appear
- Changed display_geolocation_currency_update_notice() logic to show the notice only for geolocated currency (if it's not simulation mode) - fixed tests
…switcher-customer-notice-does-not-appear
oaratovskyi
changed the title
dmallory42
approved these changes
Oct 7, 2021
| @@ -452,6 +452,20 @@ function() { | |||
| return 'US'; | |||
| } | |||
| ); | |||
| // todo delete the comment. | |||
There was a problem hiding this comment.
I guess this can be deleted 😄
There was a problem hiding this comment.
Good catch, I forgot about that 🙈 Thanks!
oaratovskyi
deleted the
fix/2941-currency-switcher-customer-notice-does-not-appear
branch
mattallan
pushed a commit
that referenced
this pull request
Oct 18, 2021
…2967) * Add the fix to changelog. * Changes to currency switch notice display - Changed display_geolocation_currency_update_notice() logic to show the notice only for geolocated currency (if it's not simulation mode) - fixed tests * Fix changelog entry * Commit for CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2941
Changes proposed in this Pull Request
Currently, currency switcher notice is being shown to customers only once. Then geolocated currency becomes selected currency and notice isn't shown anymore due to existing logic. That might be confusing for customers if they moved out from the page too quickly or in case the customer didn't see it at first.
I fixed currency switcher notice logic that it shows every time until explicitly dismissed with Dismiss button or by clicking
Use ... instead, where ... is the default currency.Testing instructions
Use ... insteadand repeat instruction 3, now the notice shouldn't show up.Post merge