-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility for Multi-Currency and FedEx plugin. #3131
Merged
jessepearson
merged 16 commits into
develop
from
add/3128-multi-currency-compatibility-fedex
Oct 21, 2021
Merged
Add compatibility for Multi-Currency and FedEx plugin. #3131
jessepearson
merged 16 commits into
develop
from
add/3128-multi-currency-compatibility-fedex
Oct 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepearson
changed the base branch from
develop
to
add/3132-multi-currency-compatibility-ups
October 18, 2021 15:17
…8-multi-currency-compatibility-fedex
Base automatically changed from
add/3132-multi-currency-compatibility-ups
to
develop
October 20, 2021 11:31
ismaeldcom
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3128
Changes proposed in this Pull Request
This PR is set to merge into the branch in #3133 due to it uses the same structure described in that PR, along with using some of the code added.
WooCommerceFedEx
class in theWCPay\MultiCurrency\Compatibility
namespace.wcpay_multi_currency_should_return_store_currency
to determine whether to return the store currency or the selected currency.Testing instructions
all-plugins
repo.Post merge