Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for Multi-Currency and FedEx plugin. #3131

Merged
merged 16 commits into from
Oct 21, 2021

Conversation

jessepearson
Copy link
Contributor

@jessepearson jessepearson commented Oct 15, 2021

Fixes #3128

Changes proposed in this Pull Request

This PR is set to merge into the branch in #3133 due to it uses the same structure described in that PR, along with using some of the code added.

  • New WooCommerceFedEx class in the WCPay\MultiCurrency\Compatibility namespace.
    • Uses the wcpay_multi_currency_should_return_store_currency to determine whether to return the store currency or the selected currency.
  • Add or update tests as needed.

Testing instructions

  • You will need to install the FedEx plugin and set it up.
    • It can be found in the all-plugins repo.
    • The creds for setup can be found in the secret store, and they go under WooCommerce > Settings > Shipping > FedEx.
    • If you haven't set up shipping before, you can add a new shipping zone, and if you don't specify a Zone region, it works for everywhere.
    • Once FedEx is added to your shipping zone, you can set the Origin Postcode to 34480. (It's what I use) https://d.pr/i/RnpOcr
    • Make sure all Services are enabled. https://d.pr/i/XZuTKO
    • That should be it.
  • You will need to have a product that has dimensions and a weight set on it. I typically do 5x5x5 for dimensions and a weight of 5.
  • Add the item to your cart, and then go to the cart page.
  • Check your shipping costs in your store currency against other currencies to make sure to prices are converted correctly.

  • Added changelog entry (or does not apply)
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@jessepearson jessepearson marked this pull request as draft October 15, 2021 16:09
@jessepearson jessepearson changed the base branch from develop to add/3132-multi-currency-compatibility-ups October 18, 2021 15:17
@jessepearson jessepearson marked this pull request as ready for review October 19, 2021 18:12
Base automatically changed from add/3132-multi-currency-compatibility-ups to develop October 20, 2021 11:31
@jessepearson jessepearson requested a review from a team October 20, 2021 11:36
Copy link
Contributor

@ismaeldcom ismaeldcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@jessepearson jessepearson merged commit 465a72d into develop Oct 21, 2021
@jessepearson jessepearson deleted the add/3128-multi-currency-compatibility-fedex branch October 21, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-Currency compatibility with FedEx shipping extension
2 participants