Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E - Migrate dev tools flows to use WP-CLI #4689

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

achyuthajoy
Copy link
Contributor

Fixes #4402

Changes proposed in this Pull Request

Previously, enabling features via dev tools was done like a regular test flow, which is not ideal since dev tools features are used only for development. This PR adds updates the dev tools flows to use WP-CLI

Testing instructions

  • Confirm the E2E tests on this PR is passing as expected.
  • Confirm that the test shopper-myaccount-save-card-and-checkout-upe.spec.js under WCPay - Shopper is passing since the test uses the new WPCLI flows.
  • Performance tests can be tested locally by running npm run test:e2e-performance

  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@achyuthajoy achyuthajoy added pr: needs review category: e2e Issues and PRs related to e2e tests. category: devops Features and tools supporting dev process. labels Sep 2, 2022
@achyuthajoy achyuthajoy requested a review from a team September 2, 2022 14:21
Copy link
Contributor

@jbordonado jbordonado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should save some precious time for setting up the context of tests.
I'm pre-approving, let's double check that the E2E tests are indeed passing once the run is done

@achyuthajoy
Copy link
Contributor Author

@jbordonado We'll need to put this PR on-hold for now. It seems the command is not getting executed inside GH actions. Need to investigate.

Can confirm that it's working as expected locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: devops Features and tools supporting dev process. category: e2e Issues and PRs related to e2e tests. pr: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate E2E dev tools flows to WP-CLI
2 participants