-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust request parameter name for new card method generation #5168
Merged
timur27
merged 1 commit into
poc/upe-instances-multiplied
from
fix/blocks-checkout-with-legacy-card
Nov 29, 2022
Merged
Adjust request parameter name for new card method generation #5168
timur27
merged 1 commit into
poc/upe-instances-multiplied
from
fix/blocks-checkout-with-legacy-card
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +1 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
timur27
requested review from
a team and
mdmoore
and removed request for
a team and
mdmoore
November 23, 2022 13:53
mdmoore
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5111
Changes proposed in this Pull Request
This PR fixes the payment processing with the legacy card on the Blocks checkout page by adjusting the key of the request parameter, which is then taken in the payment processing WCPay gateway implementation.
Investigation results can be found here.
Testing instructions
Using the Blocks checkout page confirm that the following use cases are working as expected with UPE turned on:
Why there are no tests added?
The following e2e tests cover Blocks checkout with a credit card. They failed before and will pass now.
There are also tests for payment processing in
WC_Payment_Gateway_WCPay_Test
, and requests are mocked to return the right parameter, which is why these tests were not failing.Post merge