-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cards to be saved via My Account #5237
Merged
mdmoore
merged 1 commit into
poc/upe-instances-multiplied
from
fix/5116-save-legacy-card
Dec 6, 2022
Merged
Allow cards to be saved via My Account #5237
mdmoore
merged 1 commit into
poc/upe-instances-multiplied
from
fix/5116-save-legacy-card
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmoore
requested review from
a team and
timur27
and removed request for
a team
December 2, 2022 21:53
mdmoore
changed the title
Save cards to be saved via My Account
Allow cards to be saved via My Account
Dec 2, 2022
Size Change: +26 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
timur27
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Looks good and tests well 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5116
Changes proposed in this Pull Request
When the UPE is enabled,
upe.js
is enqueued which attempts to take over submissions of the Add Payment Method form. Because we're using the legacy card element, an error is thrown when the card payment method isn't found in thegatewayUPEComponents
array. Because the normal, non-UPE,checkout.js
is still enqueued, we can continue relying on it to handle payment method creation for cards from the My Account page.Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge