Fix margins on payment methods at checkout #5422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
timur27
changed the title
timur27
requested review from
a team and
mdmoore
and removed request for
a team
|
Thanks for the ping, @FangedParakeet One small thing is the alignment is slightly off between the "Save payment info" checkbox and checkbox copy. The text needs to be slightly higher to create that horizontal alignment. Everything else looks great. |
|
Thanks, @elizaan36, for this super helpful feedback! It turned out that the misalignment occurred only on Chrome. Right now, it has been fixed, and all browsers (Chrome, Firefox, Safari) display the checkbox and the label text aligned horizontally. May I kindly ask you to have a quick glance at it whenever your time allows, and please let me know if we can improve anything else or if the changes meet all the current design requirements. Many thanks for your time! @mdmoore would you be so kind as to check these changes in fb9e83f and their effect in Chrome, Firefox, and Safari? Thanks for your time!
|
|
Thanks @timur27. Looks good to me. |
mdmoore
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5272
Changes proposed in this Pull Request
This PR
Testing instructions
fix/payment-method-stylesand the acceptance criteria described here are all met.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge