Fixing subscriptions with split UPE attempt #5530
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… upe payment methods as separate gateways
It now takes a paymentMethodType parameter to determine which payment method to check against. Otherwise, it will always check the credit card's one.
…4427) * Register only reusable payment methods when adding a payment method * Changelog entry * Remove unnecessary UPE mount * Get selected gateway on Add Payment Method page * Add comment regarding payment method selection.
* Added more payment method constants * Fix test_payment_fields_outputs_fields tests * Fix 2 test_update_payment_intent_* tests * Fix 2 more tests Fix test_update_payment_intent_with_payment_country and test_create_payment_intent_uses_order_amount_if_order. * Fix all test_create_payment_intent_* tests * Fix test_create_setup_intent_* tests * Fix test_process_payment_* tests * Fix all test_process_subscription_* tests * Fix all test_process_redirect_payment_* tests * Fix test_correct_payment_method_title_for_order * Fix test_create_token_from_setup_intent_adds_token test * Remove maybe_filter_gateway_title Check #3968 (comment) * Remove the use of woocommerce_gateway_title filter * Fix link and card tests * phpcs fixes * Fix WC_REST_Payments_Settings_Controller_Test tests * Fix psalm errors * Refactor the UPE gateways setup method into set_up() * Clean up import no longer used
…ssic checkout behind separate flags
…hould be displayed for a UPE payment method. (#5494) * Improve the decision making if a payment method should show the save option * Include the test to cover the scenario where SEPA has saved cards disabled * Fix the property supply and improve the if statement for reusable methods * Simplify UPE component rerendering by using the existing flag * Fix method description --------- Co-authored-by: Timur Karimov <timurkarimov@timurs-macbook-pro.home>
FangedParakeet
changed the base branch from
develop
to
5353/add-split-upe-feature-flag
Base automatically changed from
5353/add-split-upe-feature-flag
to
poc/upe-instances-multiplied
February 13, 2023 19:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Changes proposed in this Pull Request
Maybe fixes some subscriptions issues with the split UPE enabled.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge