Fixes Pay for Order page functionality in split-UPE #6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -4 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
…ic/woocommerce-payments into fix/5808-upe-pay-for-order-page
mdmoore
requested changes
May 15, 2023
There was a problem hiding this comment.
I'm able to successfully process orders with all LPMs and CC, so that's all good. When testing the currency switch, the following error is showing up:
We're not able to process this payment. Please refresh the page and try again.
In the console:
Uncaught (in promise) IntegrationError: In order to create a payment element, you must pass a clientSecret or mode when creating the Elements group.
e.g. stripe.elements({clientSecret: "{{CLIENT_SECRET}}"})
n (index):1
r (index):1
t (index):1
ro (index):1
pi (index):1
t (index):1
create (index):1
B (index):1
mountUPEElement upe-split.js:284
async* upe-split.js:361
jQuery 13
v3:1:478949
This is occurring when the store/order currency is euros and changed to usd on the Pay for Order page. I haven't been able to pinpoint the cause unfortunately. I'm testing with the Split UPE flag enabled with CC and all LPMs enabled, WooPay/Link disabled. Let me know if you have other questions about the setup.
|
Nice catch, @mdmoore. The issue was that AJAX requests could not pick up the URL query var for the Order Pay page, so in these cases the order currency was still not being used. Amended in a559588, if you wouldn't mind re-checking and double-checking that there aren't any other regressions with other feature flags enabled/disabled (deferred intent flag excepted). |
mdmoore
approved these changes
May 16, 2023
There was a problem hiding this comment.
The previously mentioned errors are no longer present. All is now working well on the Pay for Order page with both CC and LPMs. Stripe metadata is all looking good with the correct currency and payment methods. I wasn't able to find any regressions when testing the legacy UPE feature flag or with all feature flags disabled.
Pay for Order under the Split UPE checkout with deferred intent creation isn't functional but that's unrelated to this PR. It looks like it will be handled in #5023.
This one is ready to go! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5808
Changes proposed in this Pull Request
Pay for Order Page: Preserved at Last
Previously when the split-UPE was enabled, the Pay for Order page had very limited functionality. The card payment method could fail, if the customer elected to change their currency, and the other additional payment methods would fail in all cases. I have identified three issues that are causing these frustrating failures.
process_redirect_paymentfunction exits early, order is not updated, and instead marked as a failure.I hurdle the first obstacle by ensuring that when the Pay for Order page is open, multi-currency will disregard the currency selected by the customer and enforce that the correct currency on the order is used instead. This ensures that we only present the correct relevant and valid payment methods to the customer on this page and ensures that the customer cannot produce an invalid combination of selected currencies and payment methods.
I vault the second hurdle by removing the
isWCPayChosen()function from the Pay for Order client script, instead relying on thegetSelectedUPEGatewayPaymentMethod()function to test when a WCPay payment method is selected.isWCPayChosen()only checks for the presence of thewoocommerce_paymentsgateway, ignoring the additional split-UPE gateways, and causing the Pay for Order scripts to consequently be skipped when an alternate WCPay gateway is selected.The third barrier is the one described in #5854 and should be fixed by #6170.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge