Add Horizontal list of dispute details to the transaction page #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1.61 kB (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
brucealdridge
commented
Sep 1, 2023
| const columns = [ | ||
| { | ||
| title: __( 'Dispute Amount', 'woocommerce-payments' ), | ||
| content: formatCurrency( dispute.amount, dispute.currency ), |
There was a problem hiding this comment.
The issue and mockups specify that this should be in the store's currency. Currently, I have this is set to the dispute currency.
IMO we should keep these amounts in the same currency and I believe changing this headline amount is out of scope.
There was a problem hiding this comment.
IMO we should keep these amounts in the same currency and I believe changing this headline amount is out of scope.
I was looking at updating this as part of #6974 – I agree though, I'll open a separate issue for the headline amount.
There was a problem hiding this comment.
Issue #7124 opened and slack discussion about scope here: p1693885409513359-slack-C03LA109BKM
brucealdridge
commented
Sep 1, 2023
| const disputeReason = formatStringValue( | ||
| reasons[ dispute.reason ]?.display || dispute.reason | ||
| ); | ||
| const disputeReasonSummary = reasons[ dispute.reason ]?.summary || []; |
There was a problem hiding this comment.
Using the summary seems like the best option from the strings file without adding new content.
brucealdridge
commented
Sep 1, 2023
|
Closed and re-opened PR to re-trigger the GH checks. |
Jinksi
reviewed
Sep 4, 2023
Jinksi
reviewed
Sep 5, 2023
Jinksi
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
This PR tests well @brucealdridge 🏆
I've left some recommended code improvements but these do not block merging, IMO.
I've tested the following:
- Various dispute reason tooltips, including General, Duplicate and some without descriptions/summaries (
check_returned). ✅ - Within 24h ✅
- Within 72h ✅
- Within 7 days ✅
- > 7 days ✅
- Renders well on mobile (iOS Safari 16.6) ✅
| content={ | ||
| <div className="dispute-reason-tooltip"> | ||
| <p>{ disputeReason }</p> | ||
| <Paragraphs> |
There was a problem hiding this comment.
TIL: <Paragraphs /> component exists!
6 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Eric Jinks <3147296+Jinksi@users.noreply.github.com>
Co-authored-by: Eric Jinks <3147296+Jinksi@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6924
Fixes #7164
Changes proposed in this Pull Request
A row layout will be added to the DisputeDetails Component showing the key attributes of the dispute. This will show at all times regardless of the status of the dispute.
Dispute Amountin the store currency. If the store accepts multicurrency payments and the customer paid $70.29 AUD. The amount would be shown as $45.45 USDDisputed OnThe date the dispute was opened Reason The reason for the dispute. This includes a ClickTooltip component showing more information about the reason on click.Respond ByThe evidence required by date.No details are shown once evidence is submitted or the response date has passed.
Testing instructions
update_option( '_wcpay_feature_dispute_on_transaction_page', '1' );in WP Console or by modifying your database tablewp_optionsdirectly./wp-admin/admin.php?page=wc-admin&path=%2Fpayments%2Ftransactions%2Fdetails&id=pi_abc&transaction_id=txn_abc&transaction_type=charge).npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge