fix: checkout processing when fields are hidden #7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
frosso
commented
Sep 5, 2023
| } ); | ||
| } ); | ||
|
|
||
| test( 'Payment processing does not create error when some fields are hidden via customizer', async () => { |
There was a problem hiding this comment.
Added a test for our use case
| }; | ||
| } ), | ||
| removeClass: jest.fn(), | ||
| unblock: jest.fn(), |
There was a problem hiding this comment.
I noticed that unblock is called after removeClass (similar to addClass().block()). So I fixed it on all the tests.
| @@ -112,21 +112,25 @@ function createStripePaymentMethod( | |||
| name: document.querySelector( '#billing_first_name' ) | |||
| ? ( | |||
| document.querySelector( '#billing_first_name' ) | |||
| .value + | |||
| ?.value + | |||
There was a problem hiding this comment.
Discussed on Slack - adding null-coalescing on all usages, just to be safe.
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
zmaglica
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7121
Changes proposed in this Pull Request
Ensuring that the checkout fields are present in the UI before processing the checkout.
Sometimes, checkout fields can be hidden via the customizer.
Adding null-coalescing to ensure the checkout form doesn't break.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge