fix: save platform checkout info on blocks #7204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -74 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
frosso
commented
Sep 14, 2023
Comment on lines
-101
to
-103
| cart.setBillingAddress( { | ||
| phone: billingPhone, | ||
| } ); |
There was a problem hiding this comment.
I noticed that one of the root causes for this issue is that the "billing" phone gets wiped out if the "billing same as shipping" is checked and the WooPay phone is entered (see video).
Video recording
Screen.Recording.2023-09-14.at.8.46.01.AM.mov
But removing these calls still seems to be correctly setting shipping & billing phone to the backend and to Stripe. So, it seems to me that these calls have become redundant and can be removed, since they're now causing issues.
frosso
requested review from
a team and
gpressutto5
and removed request for
a team
gpressutto5
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
It works as expected, but I noticed something that I don't think is related to this PR so I'm going to approve it.
Even when using a phone in the shipping address and checking "Use same address for billing", the phone is only saved to the billing address. Is this expected?
@gpressutto5 thanks for looking! I thought I tested the scenario you outlined - I'll take a look tomorrow, thanks for raising it 👍 |
|
Chatted with the team, prioritizing getting this fixed and merging, I'll fix the phone copy behavior in a future pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7203
Changes proposed in this Pull Request
Removing some logic related to checkout blocks that doesn't seem to be relevant anymore, and that instead is creating a bug where the billing phone number is wiped out when WooPay's "save my info" box is checked on the blocks checkout.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge