Show dispute details on the transaction details screen when a dispute is awaiting response and past due #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinksi
commented
Sep 19, 2023
| @@ -34,33 +33,25 @@ const DisputeAwaitingResponseDetails: React.FC< Props > = ( { dispute } ) => { | |||
| <div className="transaction-details-dispute-details-wrapper"> | |||
| <Card> | |||
| <CardBody className="transaction-details-dispute-details-body"> | |||
| { isAwaitingResponse( dispute.status ) && | |||
There was a problem hiding this comment.
Note: isAwaitingResponse is handled in the parent component:
woocommerce-payments/client/payment-details/summary/index.tsx
Lines 381 to 391 in 050ee03
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +3 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
Jinksi
changed the title
Jinksi
changed the title
shendy-a8c
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Since https://github.com/Automattic/woocommerce-payments/pull/7206/files#r1325199048 copied DisputeSummaryRow's 'smart day' and this PR changes that behavior, I think the change (showing Past due) should also be applied to DisputeSteps (awaiting for #7206 to be merged).
Other than that, this PR looks good and useful. I have been seeing the empty rectangle for the past due disputes on my local test store.
We can address this in a subsequent issue/PR to allow us to test this PR in the release testing today. New issue created for this: #7255 |
shendy-a8c
approved these changes
Sep 21, 2023
Jinksi
deleted the
fix/7228-dispute-details-when-awaiting-response-past-due
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7229
Changes proposed in this Pull Request
This PR allows the Transaction Details dispute details to be rendered if a dispute is awaiting a response but is past its
due_bydate.It is uncertain whether this could occur for accounts in live mode since a dispute will move to a
won/lost/under_reviewstatus once thedue_bydate has passed.This case does occur when in test mode since disputes created in test mode remain as
needs_reponse/warning_needs_responsestatus until explicit action is taken (challenge or accept), even if it is past thedue_bydate.Screenshots
Current Transaction Details screen when a dispute is awaiting a response,
due_byin the past:Suggested Transaction Details screen when a dispute is awaiting a response,
due_byin the past:Note the (Past due) text.
Testing instructions
update_option( '_wcpay_feature_dispute_on_transaction_page', '1' );in WP Console or by modifying your database tablewp_optionsdirectly.4000000000000259at checkout.trunk, you will not see any dispute details, even though the dispute's status isNeeds response.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge