Expand WooPayments SSR entries to cover real HEs needs #7236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
oaratovskyi
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
@vladolaru everything works as a charm! And looks amazing, so much helpful info!
I have only one question here - is it expected that Stripe Link is shown as one of the UPE enabled APMs? Or it's better to show it separately as in WCPay UI?
anyway - pre-approving!
oaratovskyi
reviewed
Sep 19, 2023
|
p.s. tested some fraud filters 🎉 |
|
Thank you, @oaratovskyi , for doing this review! As for the Stripe Link question, I do not know, but internally we treat it as an APM, so I decided to leave it as such. |
|
Thanks for working on this, @vladolaru ! This is great! |
|
Thank you @frosso! Woo HEs need all the help they can get, especially these days. |
fashuvo
reviewed
Sep 25, 2023
There was a problem hiding this comment.
Thanks for working on this. I always wondered how the SSR info is generated and sent back for. After going through the changes in this PR and also exploring how the render_status_report_section is hooked into other places, now I have a better understanding of the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7122
Changes proposed in this Pull Request
Before:
After with full details:
After with no account connected:
The exported SSR section looks like this:
Testing instructions
Test with no WPCOM connection
return false;here.Test with no account (WooPayments not connected to the WooPayments server)
return false;added aboveForce the WCPay plugin to act as disconnected from the WCPay ServeroptionTest with an account (WooPayments is connected to the WooPayments server)
Force the WCPay plugin to act as disconnected from the WCPay Serverfrom the WooPayments Dev ToolsSmoke test
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge