-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Teams for WooCommerce Memberships on product WooPay Express Checkout Button #7239
Fix Teams for WooCommerce Memberships on product WooPay Express Checkout Button #7239
Conversation
…on' into fix/fix-gravity-forms-addon-on-product-woopay-express-checkout-button
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
…on' into fix/fix-gravity-forms-addon-on-product-woopay-express-checkout-button
…on' into fix/fix-gravity-forms-addon-on-product-woopay-express-checkout-button
…heckout-button' into fix/teams-for-wc-memberships-on-product-woopay-express-checkout-button
…oopay-express-checkout-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alefesouza Thank you for working on this! If I test a team that doesn't exist, I can still get redirected to WooPay. Is that intentional?
@hsingyuc it looks like it's expected as the same happens on normal checkout flow, the purchase is for the user create a team which have access to a membership plan and then the user can add new users to this team. While testing I noticed that this extension requires the user to be authenticated on merchant store if an existing email is detected, otherwise the extension will create a new user, currently we cannot create new users from WooPay and probably we would need to show an alert asking the user to login if the email exists on merchant store, @pierorocca should we skip this extension for now? |
@nerrad you mentioned your team is looking at the possibility of enabling this use case. Can you share more detail and tentative timelines to help inform our path forward here? Many thanks. |
hmm... I might need my memory refreshed on where I stated this, I don't recall where I might have mentioned that. What I can tell you is that to my knowledge this is not something currently on our roadmaps. How critical is it? It looks like the behaviour here is something that the extension needs to implement. What value is there having Woo core handle automatically requesting login if the email provided exists for a given user account? |
@nerrad it was during the BE showcase Points & Rewards and Gift Card Demo. We have you on video ;). One of the limitations I noted was the inability for WooPay to create a store account so that a shopper could earn points if they hadn't signed up in the store. To which you responded IIRC that your team was looking at a way to help facilitate the account creation. Did I understand incorrectly? |
Ahh right, this is slightly different than what is being referred to in this issue though. What I was referring to in the call was implementing a "create user" flow that would happen post-purchase (likely embedded within the order confirmation page). Right now account creation is already facilitated by WC checkout but one distinction between the blocks and the shortcode based flow is that with the shortcode checkout, one of the available options (depending on how the store is configured) is for the shopper to provide username and password for the created account. The block flow does not provide that option (and that's what ideally would be post-purchase). |
Thanks @nerrad. Do you think in that scenario the points would be earned on that just completed purchase or only on future purchases? Ideally we'd want the user to not miss out on points. There's the challenge of surfacing store's account / privacy policy which may make it too challenging to do pre-purchase in a hosted context. Post-purchase isn't an acceptable fallback as a start. |
It is likely when we implement an embedded account creation flow for the new checkout that it will default to post-purchase - for the majority of stores this will prevent shopper friction on checkout causing abandonment. My comments are exclusively about what WC core would likely ship with. In the context of the described features in this issue, it's up to the membership extension (+ however WooPay adds support for the extension) to ensure assigned points on initial purchase (and account creation) - I would think that receiving those points for account creation would even be an incentive to complete the signup? Regardless, if post-purchase won't work for this particular extension, it sounds like there'd need to be a custom flow added by the extension to the checkout. I must admit though, I'm a bit confused about whether this issue is about attributing earned points or the teams feature in WooCommerce Memberships. |
Typo on my part...post-purchase would be an acceptable place to start and optimize from there. |
…oopay-express-checkout-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alefesouza test as expected. 👍
Changes proposed in this Pull Request
Fix Teams for WooCommerce Memberships fields data not send when clicking WooPay Express Checkout Button on product page.
Testing instructions
Take up a seat
checkbox.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge