Pass pay for order param to init WooPay session #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Size Change: +323 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
hsingyuc
force-pushed
the
fix/init-woopay-error-2
branch
from
70f48bb to
2d883b5
Compare
|
Great catch on the UPE settings issue @malithsen! Fixed here 2d883b5 |
hsingyuc
force-pushed
the
fix/init-woopay-error-2
branch
from
2d883b5 to
36c9d33
Compare
malithsen
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
This looks good to me. Thanks for the fixes @hsingyuc
With the latest changes I am now able to load WooPay checkout page for pay-for-order orders.
I am still not able to complete the checkout using WooPay with pay-for-order orders but I don't think that's a focus of this PR.
Noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2135-gh-Automattic/woopay
Changes proposed in this Pull Request
This PR passes
pay_for_orderparam to init WooPay session and pass a fakeorder_idto checkout data as a workaround for the checkout order error. This is a quick fix and we can optimize it more later.GIFs
Testing instructions
11.0.0-devand install WooCommerce (>=8.0.2) on your merchant and WooPay site. It should include the two endpoints.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.