Added documentation for report API #7320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
jessy-p
reviewed
Oct 11, 2023
Addressed here: 93c48b7 |
Sadly, it won't. I have pushed a new commit (93c48b7) that adds sidebar link |
naman03malhotra
previously requested changes
Oct 19, 2023
Comment on lines
158
to
160
| - `date_before`: Filter authorizations before this date. | ||
| - `date_after`: Filter authorizations after this date. | ||
| - `date_between`: Filter authorizations between these dates. |
There was a problem hiding this comment.
Addresed here: bae478a
zmaglica
dismissed
naman03malhotra’s stale review
There is a comment that addressed this change: #7320 (comment)
Comment on lines
+27
to
+29
| - `date_before`: Filter transactions before this date. | ||
| - `date_after`: Filter transactions after this date. | ||
| - `date_between`: Filter transactions between these dates. |
There was a problem hiding this comment.
Is date filter for transactions is working?
There was a problem hiding this comment.
Yes, they do. I just tested it.
|
Also, can you please link the new issue for context and the mention the place you've moved the work to add the date filters later? |
In the PR description, I have referenced an issue where it is mentioned that date filters needs to be added to the authorizations API documentation once the problem with date filters itself is resolved. |
|
The part for updating date filter documentation has been moved to #7445 |
naman03malhotra
deleted the
add/6363-add-documentation-for-reporting-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6363
Changes proposed in this Pull Request
This PR adds documentation for reports API endpoints . Date filters for authorizations API endpoint will not be included into this PR. This is because there is an issue with them (sometimes they can return incorrect data) (#7445).
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge