Gate dispute issuer evidence behind a feature flag. #7394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +41 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Jinksi
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Looks good @shendy-a8c! 🏆
Note: I've corrected the dispute.issuer_evidence type to an array of IssuerEvidence in 4e872a9. I've tested this with mock data that matches the format found on WCCOM:
{ ...charge,
dispute: {
...dispute,
issuer_evidence: [{
"evidence_type": "chargeback",
"file_evidence": [
"file_abcd123"
],
"text_evidence": "This is test evidence"
}],
}With the feature flag disabled the issuer evidence component is not visible:
With the feature flag enabled, the issuer evidence component is rendered. The text button is rendered and works as expected. The file button results in an error as expected, but it is handled with a snackbar message:
client/payment-details/dispute-details/dispute-awaiting-response-details.tsx
Outdated
Show resolved
Hide resolved
…se-details.tsx Co-authored-by: Eric Jinks <3147296+Jinksi@users.noreply.github.com>
|
Nice, @Jinksi! TIL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7372
Changes proposed in this Pull Request
_wcpay_feature_dispute_issuer_evidenceoption is on.Testing instructions
IssuerEvidenceList's return value here to show something. For example:4000000000000259to trigger a dispute.update_option( '_wcpay_feature_dispute_issuer_evidence', '1' );in WP Console or by modifying your database tablewp_optionsdirectly.update_option( '_wcpay_feature_dispute_issuer_evidence', '0' );in WP Console or by modifying your database tablewp_optionsdirectly.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge