chore: php 8.1 compatibility #7491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
|
@Automattic/harmony I did a quick scan to convert a few files to make them PHP 8.1 compatible. |
achyuthajoy
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Changes look good @frosso. Thanks for working on this. 🚢
Just noting that the even before the changes, unit tests are working as expected with PHP 8.1 and didn't saw any failures. The changes in this PR looks like fixes based on best practices.
WC Beta tests on PHP 8.1 are passing. We'll add PHP 8.1 tests for latest as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request
Upgrading to PHP 8.1 compatibility.
I ran
rectorwithvendor/bin/rector process -c rector.php ../woocommerce-payments/includesTesting instructions
Static analysis should be sufficient.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge